Fix empty key exception in raw tag editor and clean up linting spacing#12043
Open
JaiswalShivang wants to merge 3 commits intoopenstreetmap:developfrom
Open
Fix empty key exception in raw tag editor and clean up linting spacing#12043JaiswalShivang wants to merge 3 commits intoopenstreetmap:developfrom
JaiswalShivang wants to merge 3 commits intoopenstreetmap:developfrom
Conversation
Member
|
Unfortunately, this does not seem to fix the glitch: Screencast.From.2026-03-18.17-49-19.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: [#11970 ]
Description
This PR addresses a bug in the raw tag editor where completely emptying a tag key could dispatch an unwanted or malformed change event. Additionally, it resolves some lingering ESLint formatting warnings in the file.
Changes made
if (!kNew) return;return in [raw_tag_editor.js] to prevent the editor from attempting to process and dispatch tag changes when a user clears a key input.Testing
npm run test:once).